ktmud commented on a change in pull request #12875:
URL: https://github.com/apache/superset/pull/12875#discussion_r569208067
##########
File path: superset/security/manager.py
##########
@@ -417,6 +418,27 @@ def can_access_table(self, database: "Database", table:
"Table") -> bool:
return True
+ def raise_for_dashboard_access(self, dashboard: "Dashboard") -> None:
Review comment:
It's worth adding feature flag checks here, too, just in case this
method was accidentally invoked outside of a feature flag enabled brach.
As a general note, unless it's refactoring that will also benefit the base
case, new code for feature flags should all wrap behind the flag because it
would also make cleaning up the feature flag easier (hope we don't have to do
it for this case, though!).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
