amitmiran137 commented on a change in pull request #12875:
URL: https://github.com/apache/superset/pull/12875#discussion_r569673638
##########
File path: tests/dashboards/security/security_rbac_tests.py
##########
@@ -129,6 +253,23 @@ def
test_get_dashboards_list__user_get_only_published_permitted_dashboards(self)
for dash in published_dashboards + not_published_dashboards:
revoke_access_to_dashboard(dash, new_role)
+ def __arrange_only_published_permitted(self):
Review comment:
my bad on the double underscore.
the name you're suggesting will not indicate its meaning
the purpose of this method is to arrange a scenario matching to tests using
it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
