rusackas commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r569790091
##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -145,13 +146,38 @@ export default class SqlEditorLeftBar extends
React.PureComponent {
<div className="divider" />
<StyledScrollbarContainer>
<StyledScrollbarContent contentHeight={tableMetaDataHeight}>
- {this.props.tables.map(table => (
- <TableElement
- table={table}
- key={table.id}
- actions={this.props.actions}
- />
- ))}
+ <Collapse
+ ghost
+ expandIconPosition="right"
+ css={theme => css`
Review comment:
I'm kind of on the fence. Both are kind of nice. The `css` prop is good
for all the reasons you mention. The `styled.x` approach is also nice because
it's kind of like having a CSS file , and you can put multiples of them in a
single file in one place. Unless there's a performance difference (or one makes
the stupid sourcemaps actually _work_) then I'm pretty ambivalent, so long as
we use the Theme vars wherever we can, and kill off any legacy LESS we no
longer need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
