rusackas commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r578209886
##########
File path:
superset-frontend/src/explore/components/controls/FixedOrMetricControl.jsx
##########
@@ -107,67 +100,88 @@ export default class FixedOrMetricControl extends
React.Component {
return (
<div>
<ControlHeader {...this.props} />
- <Label onClick={this.toggle}>
- {this.state.type === controlTypes.fixed && (
- <span>{this.state.fixedValue}</span>
- )}
- {this.state.type === controlTypes.metric && (
- <span>
- <span style={{ fontWeight: 'normal' }}>metric: </span>
- <strong>
- {this.state.metricValue ? this.state.metricValue.label : null}
- </strong>
- </span>
- )}
- </Label>
- <Panel
- className="panel-spreaded"
- collapsible
- expanded={this.state.expanded}
- onToggle={this.toggle}
+ <Collapse
+ ghost
+ css={css`
+ &.ant-collapse
+ > .ant-collapse-item.ant-collapse-no-arrow
+ > .ant-collapse-header {
+ border: 0px;
+ padding: 0px 0px 8px 0px;
Review comment:
```suggestion
padding: 0px 0px 8px 0px;
```
Nit, but would be nice to use `gridUnit`s here and in the `.well` selector
below.
Also, I think this deep selector is definitely better than `!important`, but
now I'm _just curious_ if we can tack on an `id` to the element itself, and use
`&#someID.ant-...` to to throw a little more value at the selector weighting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
