ktmud commented on a change in pull request #12875:
URL: https://github.com/apache/superset/pull/12875#discussion_r569811666
##########
File path: superset/models/dashboard.py
##########
@@ -407,3 +422,22 @@ def clear_dashboard_cache(
sqla.event.listen(TableColumn, "after_update", clear_dashboard_cache)
sqla.event.listen(DruidMetric, "after_update", clear_dashboard_cache)
sqla.event.listen(DruidColumn, "after_update", clear_dashboard_cache)
+
+
+def raise_for_dashboard_access(dashboard: Dashboard) -> None:
+ from superset.views.base import get_user_roles, is_user_admin
+ from superset.views.utils import is_owner
+
+ if is_feature_enabled("DASHBOARD_RBAC"):
+ has_rbac_access = any(
+ dashboard_role.id in [user_role.id for user_role in
get_user_roles()]
+ for dashboard_role in dashboard.roles
+ )
+ can_access = (
+ is_user_admin()
+ or is_owner(dashboard, g.user)
+ or (dashboard.published and has_rbac_access)
+ )
+
+ if not can_access:
+ raise DashboardAccessDeniedError()
Review comment:
Sounds good. I'm thinking we may even introduce a new `Mixin` for all
entities with role based access, but that can happen later when we do introduce
RBAC to more entities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
