junlincc commented on pull request #12918:
URL: https://github.com/apache/superset/pull/12918#issuecomment-772889577


   thanks for the PR @simcha90 ! User will still be able to add filters after 
hiding header and edit button. is this intended? 
   @mihir174 I think this is a valid user need - sharing a dashboard to other 
that should not be editing it. this solution to me is a bit "hacky" though. any 
idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to