junlincc edited a comment on pull request #12918: URL: https://github.com/apache/superset/pull/12918#issuecomment-772889577
thanks for the PR @simcha90 ! User will still be able to add filters after hiding header and edit button since the actions take place in the view mode. is this intentional? @mihir174 I think this is a valid user need - sharing a dashboard to those who should not be editing it. this solution to me is a bit "hacky" though. any idea? feature works as expected! <img width="1787" alt="Screen Shot 2021-02-03 at 3 15 48 PM" src="https://user-images.githubusercontent.com/67837651/106821824-c4bc3a00-6632-11eb-8146-3993df429d52.png";> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/106821824-c4bc3a00-6632-11eb-8146-3993df429d52.png"](https://user-images.githubusercontent.com/67837651/106821824-c4bc3a00-6632-11eb-8146-3993df429d52.png"){kind=link}