villebro commented on issue #12907:
URL: https://github.com/apache/superset/issues/12907#issuecomment-773857917


   @rwspielman now that it has been migrated the table chart to the new chart 
data endpoint (see #10270), it is finally possible to add a total row to the 
table chart. The reason this wasn't possible before is because legacy charts 
were really only able to do single query requests, making it difficult to get 
both row level data and aggregates for the whole dataset. With the new 
architecture, it's possible to issue multiple queries to the backend for a 
single chart rendering. In practice this feature would require issuing a second 
query to the analytical database, where the groupings have been removed, and 
only the metrics are present.
   
   @amitmiran137 I know your team has been thinking about working on this 
functionality. Have you considered how pagination would be taken into account 
when displaying results? I personally think think
   - The total should display the value for all metrics without grouping: if a 
metric is `AVG(x)`, the total row would display the average for the whole 
column.
   - In addition to showing the aggregate metric values, it would also show 
total row count.
   - The total row would be visible all the time, showing results for ALL rows, 
not only those visible in the current pagination view.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to