TColl removed a comment on pull request #12806: URL: https://github.com/apache/superset/pull/12806#issuecomment-774019433
One thing to watch out for with this approach - we lose the [pandas sense-check](https://github.com/pandas-dev/pandas/blob/cb1486c8ef53db474248a0f9b81937b487388431/pandas/core/frame.py#L1568) that all columns have unique names and hence the warning about the resulting dicts not reflecting the source data if they aren't. It'd be easy enough to add this check into our function here too - either via `warnings.warn()` or through the logger. What would be preferred? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
