TColl removed a comment on pull request #12806: URL: https://github.com/apache/superset/pull/12806#issuecomment-774447881
I've added the check/warning and updated my [benchmarking notebook](https://colab.research.google.com/drive/1_b2KKFrscNsbzceocxNpoNHGTS-IHbSL?usp=sharing) to include the latest code - I'm still seeing a 2x improvement for large dataframes, and more like 5-6x speedup on smaller dataframes. Either way, I think this is good to go now! I'm surprised you didn't see similar improvements in your tests - could you share what you've tried so I can have a look? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
