eschutho commented on a change in pull request #12873:
URL: https://github.com/apache/superset/pull/12873#discussion_r571194725
##########
File path: superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
##########
@@ -94,54 +74,45 @@ export default class TemplateParamsEditor extends
React.Component {
</a>{' '}
syntax.
</p>
- );
- }
+ <StyledConfigEditor
+ keywords={[]}
+ mode={language}
+ minLines={25}
+ maxLines={50}
+ onChange={onChange}
Review comment:
here I think we can add a throttle or debounce from the lodash library
so that we don't introduce any race conditions with the redux actions. I think
the throttle may feel more natural, but either could work. Something like
`onChange={throttle(onChange, 200)}` should be all you need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
