eschutho commented on a change in pull request #12873:
URL: https://github.com/apache/superset/pull/12873#discussion_r571253614
##########
File path: superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
##########
@@ -94,54 +75,45 @@ export default class TemplateParamsEditor extends
React.Component {
</a>{' '}
syntax.
</p>
- );
- }
+ <StyledConfigEditor
+ keywords={[]}
+ mode={language}
+ minLines={25}
+ maxLines={50}
+ onChange={throttle(onChange, 200)}
Review comment:
This is great. I tested with both throttle and debounce, and it seems
that debounce actually is more seamless. We should prob use that instead. Sorry
about that. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
