ktmud commented on pull request #13037:
URL: https://github.com/apache/superset/pull/13037#issuecomment-776932740


   @michael-s-molina Thanks for the quick simulation! 
   
   I think this works for the dashboard page. For the Explore page though, 
looking at this more, I'm now no so sure about replacing the icon as it's not 
very clear what does a copy icon mean. Most first-time users would probably 
associate it with copying the data, the query, or the chart metadata, not a 
short-url.
   
   Here's another proposal: wow about we keep the popover but make it open on 
hover and remove the animation? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to