[GitHub] [superset] michael-s-molina commented on pull request #13037: feat: add autocopy functionality to CopyToClipboard (#10328)

[GitBox]

michael-s-molina commented on pull request #13037:
URL: https://github.com/apache/superset/pull/13037#issuecomment-779333060


   In this last commit I did the following changes in addition to original 
changes:
   
   - Changed icons to use Icon component except for JSON and CSV because we 
don’t have equivalent icons yet. Maybe with Diego's PR 
(https://github.com/apache/superset/pull/12229) we can replace these in the 
future.
   - When clicked copy and email buttons were generating a different short URL 
even when the main URL had no change. I fixed this to avoid unnecessary POST 
requests.
   
   - Added tooltip for all action buttons in Explore
   
   
![hover](https://user-images.githubusercontent.com/70410625/107971112-cd950000-6f90-11eb-9db7-f883de87dbd7.gif)
   
   
   - Removed outline border when active
   
   <img width="294" alt="Screen Shot 2021-02-12 at 9 14 22 AM" 
src="https://user-images.githubusercontent.com/70410625/107971147-db4a8580-6f90-11eb-9d7a-19cdc6bd4c0e.png";>
   
   - Changed dashboard copy/email from modal to menu item
   
   <img width="1767" alt="Screen Shot 2021-02-15 at 8 52 26 AM" 
src="https://user-images.githubusercontent.com/70410625/107971839-befb1880-6f91-11eb-9963-cf3e3c6f7758.png";>
   
   - Changed chart copy/email from modal to menu item
   
   <img width="573" alt="Screen Shot 2021-02-15 at 8 52 10 AM" 
src="https://user-images.githubusercontent.com/70410625/107971589-6f1c5180-6f91-11eb-8ed5-dc37d86fc666.png";>
   
   
   I also created a React hook called `useUrlShortener` for the cases where we 
need a short version of an URL.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org