willbarrett commented on a change in pull request #13051:
URL: https://github.com/apache/superset/pull/13051#discussion_r574103505
##########
File path: superset/config.py
##########
@@ -1057,6 +1057,10 @@ class CeleryConfig: # pylint:
disable=too-few-public-methods
'class="alert-link">here</a>.'
)
+# Turn this key to False to disable ownership check on the old dataset MVC and
+# datasource API /datasource/save.
+OLD_API_CHECK_DATASET_OWNERSHIP = True
Review comment:
Hrm... @etr2460 before this point, my understanding was that this was a
hole in our RBAC configuration, and what this flag was for was to allow
organizations time to migrate their existing data. If this is a requirement on
Superset going forward then I think it would be good to discuss it. @dpgaspar
mentioned that he thinks eventually migrating to a group permission rather than
an individual permission could accommodate this need - anyone in a specified
group would be able to edit the datasource, rather than a list of owners. Can
you talk more about how this is relied on at Airbnb? Would providing a group as
the "owner" of the datasource resolve the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
