etr2460 commented on a change in pull request #13051:
URL: https://github.com/apache/superset/pull/13051#discussion_r574126735
##########
File path: superset/config.py
##########
@@ -1057,6 +1057,10 @@ class CeleryConfig: # pylint:
disable=too-few-public-methods
'class="alert-link">here</a>.'
)
+# Turn this key to False to disable ownership check on the old dataset MVC and
+# datasource API /datasource/save.
+OLD_API_CHECK_DATASET_OWNERSHIP = True
Review comment:
Providing a group could fix this, as long as it's easy to make sure
everyone is in that group (not sure what group means in this case, are we
talking about a role like `Alpha` or `Gamma`?).
Basically we rely on this because many physical datasets are used by many
people on many teams (think a table like `bookings`). Many people would want to
build charts based off this table, and make calculated columns or metrics that
could be shared across other charts or to other people (maybe there's a
calculated column called `is_weekend` that does logic based on the dttm the
booking is). We want to enable and encourage this behavior, otherwise we'd end
up in a situation where there are dozens of physical datasets for `bookings`,
each with different metrics and calculated columns (and even worse, different
definitions of the same metrics or calculated columns).
Finally, while we do want everyone to be able to take some actions on a
dataset (adding metrics, calculated columns, better column descriptions, etc.)
it would be nice to restrict other actions to owners only (deleting the
dataset, changing the SQL of a virtual dataset). In an ideal world, we'd have
more fine grain permission on datasets that could allow anyone to do
non-destructive actions, but only let owners/admins perform destructive ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
