suddjian commented on a change in pull request #13087:
URL: https://github.com/apache/superset/pull/13087#discussion_r575607941
##########
File path: superset-frontend/src/components/Menu/MenuObject.tsx
##########
@@ -36,16 +37,28 @@ export interface MenuObjectProps {
url?: string;
childs?: (MenuObjectChildProps | string)[];
isHeader?: boolean;
+ frontEndRoutes?: {
+ [route: string]: boolean;
+ };
}
Review comment:
I think one place or another we'll need to have a list of frontend
routes, at least until all routes become assimilated.
##########
File path: superset-frontend/src/components/Menu/MenuObject.tsx
##########
@@ -36,16 +37,28 @@ export interface MenuObjectProps {
url?: string;
childs?: (MenuObjectChildProps | string)[];
isHeader?: boolean;
+ frontEndRoutes?: {
+ [route: string]: boolean;
+ };
}
Review comment:
I think one place or another we'll need to have a list of frontend
routes, until all routes become assimilated into the react frontend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
