nytai commented on a change in pull request #13087:
URL: https://github.com/apache/superset/pull/13087#discussion_r575714541
##########
File path: superset-frontend/src/components/Menu/MenuObject.tsx
##########
@@ -36,16 +37,28 @@ export interface MenuObjectProps {
url?: string;
childs?: (MenuObjectChildProps | string)[];
isHeader?: boolean;
+ frontEndRoutes?: {
+ [route: string]: boolean;
+ };
}
Review comment:
We could have a `routes.tsx` module where we keep the list of route &
component pairs, along with other util functions like `isFrontendRoute`. That
should help abstract away some of the stuff that's currently in the
`src/views/App.tsx` module such as ErrorBoundary wrapping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
