michael-s-molina commented on pull request #13037: URL: https://github.com/apache/superset/pull/13037#issuecomment-780579786
> Code LGTM with a couple of small comments. > > A small UX suggestion: instead of using toast, you may also just updated the tooltip when copied was successful (you can even show a "Loading..." while fetching the shortened URL in the tooltip, too) > > <img alt="copied-to-clipboard" width="324" src="https://user-images.githubusercontent.com/335541/108005424-8c5f1900-6fad-11eb-9cb6-4700e3fb20b3.png";> Accepted you suggestion. Now we update the tooltip. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/108005424-8c5f1900-6fad-11eb-9cb6-4700e3fb20b3.png"](https://user-images.githubusercontent.com/335541/108005424-8c5f1900-6fad-11eb-9cb6-4700e3fb20b3.png"){kind=link}