ktmud commented on a change in pull request #13037:
URL: https://github.com/apache/superset/pull/13037#discussion_r576476076
##########
File path: superset-frontend/src/explore/components/ExploreActionButtons.jsx
##########
@@ -115,6 +163,19 @@ export default function ExploreActionButtons({
/>
</div>
);
-}
+};
+
+ExploreActionButtons.propTypes = {
+ actions: PropTypes.object.isRequired,
+ canDownload: PropTypes.oneOfType([PropTypes.string, PropTypes.bool])
+ .isRequired,
+ chartStatus: PropTypes.string,
+ chartHeight: PropTypes.string.isRequired,
+ latestQueryFormData: PropTypes.object,
+ queriesResponse: PropTypes.arrayOf(PropTypes.object),
+ slice: PropTypes.object,
+ addDangerToast: PropTypes.func.isRequired,
+ addSuccessToast: PropTypes.func.isRequired,
+};
Review comment:
Next time, if we are to update `propTypes`, might as well just convert
the whole component into `tsx` first.
You could also convert it to a functional component and use the `useToasts`
hook.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
