yardz opened a new pull request #13179:
URL: https://github.com/apache/superset/pull/13179


   ### SUMMARY
   This PR is for improving code coverage.
   Inside the folder `/superset-frontend/src/component`  there is the 
`Loading.tsx` component, which had no tests or storybook.
   In this PR, I am making the following changes:
   - Moving the file to the "Loading/index" folder to maintain compatibility 
with imports that already exist.
   - Creating the storybook for the component
   - Creating unit tests for the component. Ensuring that it is working properly
   
   In order to make the storybook work properly, it was necessary to insert a 
new prop (optional), which receives the path of the loading image.
   When creating the build, the images are placed in the folder 
`/static/assets/images/` while in the storybook it is not possible to make this 
mapping and the images are in the "/images/" folder. The prop "image" has been 
inserted to make it possible to display the image correctly. However, the 
default value of this prop remains the original value, not changing the current 
behavior


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to