yardz commented on a change in pull request #13179:
URL: https://github.com/apache/superset/pull/13179#discussion_r577847481
##########
File path: superset-frontend/src/components/Loading/index.tsx
##########
@@ -41,12 +42,16 @@ const LoaderImg = styled.img`
transform: translate(-50%, -50%);
}
`;
-export default function Loading({ position = 'floating' }: Props) {
+export default function Loading({
+ position = 'floating',
+ image = '/static/assets/images/loading.gif',
+}: Props) {
return (
<LoaderImg
className={`loading ${position}`}
alt="Loading..."
- src="/static/assets/images/loading.gif"
+ src={image}
+ data-test-id="loading"
Review comment:
As for role, boostrap uses `role="status"`
https://getbootstrap.com/docs/4.4/components/spinners/
I will make these changes in case you agree, it’s already easier to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
