rusackas commented on a change in pull request #13002:
URL: https://github.com/apache/superset/pull/13002#discussion_r577883280
##########
File path: superset-frontend/src/dashboard/components/menu/PopoverDropdown.jsx
##########
@@ -89,25 +90,31 @@ class PopoverDropdown extends React.PureComponent {
const { id, value, options, renderButton, renderOption } = this.props;
const selected = options.find(opt => opt.value === value);
return (
- <DropdownButton
+ <Dropdown
id={id}
- bsSize="small"
- title={renderButton(selected)}
- className="popover-dropdown"
+ trigger="click"
+ overlayStyle={{ zIndex: 3001 }}
Review comment:
I'm a little hesitant about random zIndex values re-appearing in the
codebase after making some effort to consolidate them. I see a couple paths
forward:
• Making a z-index registry in the Theme (painful for now, due to the
external repo)
• Exporting a z-index value from the Popover itself, and importing here to
reference/increment.
... there might be other ways too, just to keep collisions/codependencies
from arising. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
