michael-s-molina commented on a change in pull request #13002:
URL: https://github.com/apache/superset/pull/13002#discussion_r578430153



##########
File path: superset-frontend/src/dashboard/components/menu/PopoverDropdown.jsx
##########
@@ -78,6 +78,7 @@ const MenuItem = styled(Menu.Item)`
 class PopoverDropdown extends React.PureComponent {

Review comment:
       I agree with the suggestion in a separate PR. I added this component to 
our tests audit spreadsheet with the following notes: 
   
   > We should move this to the components folder, change it to a functional 
component with typescript, create tests and storybook




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to