eschutho commented on a change in pull request #13182:
URL: https://github.com/apache/superset/pull/13182#discussion_r577911975
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -39,7 +40,19 @@ interface DatabaseModalProps {
database?: DatabaseObject | null; // If included, will go into edit mode
}
+// todo: define common type fully in types file
+interface RootState {
+ common: {
+ conf: {
+ SQLALCHEMY_DOCS_URL: string;
+ };
+ };
+ messageToast: Array<Object>;
+}
+
const DEFAULT_TAB_KEY = '1';
+const DEFAULT_SQLALCHEMY_DOCS_URL =
+ 'https://docs.sqlalchemy.org/en/rel_1_2/core/engines.html#';
Review comment:
Actually I see you also have it there.. seems like unless someone
overwrites it with an empty string in their own config, it should always exist
and we shouldn't need a default here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
