eschutho commented on a change in pull request #13182:
URL: https://github.com/apache/superset/pull/13182#discussion_r577912389
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -402,7 +419,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
<div className="helper">
{t('Refer to the ')}
<a
-
href="https://docs.sqlalchemy.org/en/rel_1_2/core/engines.html#";
+ href={conf?.SQLALCHEMY_DOCS_URL ?? DEFAULT_SQLALCHEMY_DOCS_URL}
Review comment:
per above, it seems that just conf.SQLALCHEMY_DOCS_URL should always
have a value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
