[GitHub] [superset] iercan commented on a change in pull request #13157: fix: Report and thumbnails will use values from WEBDRIVER_WINDOW option

Thu, 18 Feb 2021 01:36:21 -0800 


iercan commented on a change in pull request #13157:
URL: https://github.com/apache/superset/pull/13157#discussion_r578265749



##########
File path: superset/config.py
##########
@@ -946,7 +946,7 @@ class CeleryConfig:  # pylint: 
disable=too-few-public-methods
 WEBDRIVER_TYPE = "firefox"
 
 # Window size - this will impact the rendering of the data
-WEBDRIVER_WINDOW = {"dashboard": (1600, 2000), "slice": (3000, 1200)}
+WEBDRIVER_WINDOW = {"dashboard": (1600, 3000), "slice": (1280, 960)}

Review comment:
       In my tests too big slice resolution makes pictures blur too much. Here 
is result for 3000x1200 and 1280x960
   
![image](https://user-images.githubusercontent.com/3406152/108336911-9703f300-71e5-11eb-8e8d-8f59ec777e74.png)
   
![image](https://user-images.githubusercontent.com/3406152/108337108-d16d9000-71e5-11eb-962a-9fe2497c62e4.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to