iercan commented on a change in pull request #13157:
URL: https://github.com/apache/superset/pull/13157#discussion_r578339256
##########
File path: superset/reports/commands/execute.py
##########
@@ -152,11 +152,19 @@ def _get_screenshot(self) -> ScreenshotData:
screenshot: Optional[BaseScreenshot] = None
if self._report_schedule.chart:
url = self._get_url(standalone="true")
- screenshot = ChartScreenshot(url,
self._report_schedule.chart.digest)
+ screenshot = ChartScreenshot(
+ url,
+ self._report_schedule.chart.digest,
+ window_size=app.config["WEBDRIVER_WINDOW"]["slice"],
Review comment:
Yeah I used config value as default but maybe in future default value
could change thats why I thought it is better to provide it from init function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
