michael-s-molina commented on a change in pull request #13002:
URL: https://github.com/apache/superset/pull/13002#discussion_r578603707
##########
File path: superset-frontend/src/dashboard/components/menu/PopoverDropdown.jsx
##########
@@ -89,25 +90,31 @@ class PopoverDropdown extends React.PureComponent {
const { id, value, options, renderButton, renderOption } = this.props;
const selected = options.find(opt => opt.value === value);
return (
- <DropdownButton
+ <Dropdown
id={id}
- bsSize="small"
- title={renderButton(selected)}
- className="popover-dropdown"
+ trigger="click"
+ overlayStyle={{ zIndex: 3001 }}
+ overlay={
+ <Menu onClick={this.handleSelect}>
+ {options.map(option => (
+ <MenuItem
+ id="menu-item"
+ key={option.value}
+ className={cx('dropdown-item', {
+ active: option.value === value,
+ })}
+ >
+ {renderOption(option)}
+ </MenuItem>
+ ))}
+ </Menu>
+ }
>
- <Menu onClick={this.handleSelect}>
- {options.map(option => (
- <MenuItem
- key={option.value}
- className={cx('dropdown-item', {
- active: option.value === value,
- })}
- >
- {renderOption(option)}
- </MenuItem>
- ))}
- </Menu>
- </DropdownButton>
+ <div role="button" css={{ display: 'flex', alignItems: 'center' }}>
+ {renderButton(selected)}
+ <Icon name="caret-down" css={{ marginTop: 4 }} />
Review comment:
I really prefer this detailed review to a superficial one. It's very
important to keep our standards intact. 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
