rijojoseph07 opened a new pull request #13214: URL: https://github.com/apache/superset/pull/13214
### SUMMARY Fix for issue https://github.com/apache/superset/issues/11359, https://github.com/apache/superset/issues/9406 When using LDAP authentication with presto/trino, the current behavior is just to modify the URL to replace the username which will result in an unauthorized exception. This PR will fix this by updating the connection argument with the effective user. ### TEST PLAN Step 1: Setup database connection to presto without credentials in URL. Step 2: Provide admin(who can impersonate as any other user in presto) credentials in connection properties via extras ``` "engine_params": { "connect_args":{ "protocol": "https", "username":"<admin>", "password":"<admin_password>" } } ``` Step 3: Enable impersonation for the database connection. Step 4: Log in with a different user and run the query via SQL lab and you will see the **principal user** as admin and **user** as the logged-in user in presto UI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
