willbarrett commented on pull request #13214: URL: https://github.com/apache/superset/pull/13214#issuecomment-782217532
A way forward if it's not possible to get the connect args out of SQLAlchemy would be to mock the `create_engine` call on line 364 in `superset/models/core.py` and assert on the arguments passed in. These systems for connecting to many different database types are quite challenging the community to test, so comprehensive unit test coverage is important for quality. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
