michael-s-molina commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r579155136
##########
File path: superset-frontend/src/common/components/Collapse/index.tsx
##########
@@ -18,11 +18,10 @@
*/
import React from 'react';
import { styled } from '@superset-ui/core';
-// eslint-disable-next-line no-restricted-imports
-import { Collapse as AntdCollapse } from 'antd';
+import { Collapse as AntdCollapse } from 'src/common/components';
Review comment:
I totally agree. This happened because of the ESLint rule
`no-restricted-imports` that prevented AntD imports and recommended imports
from `src/common/components`. To fix this, I created two `.eslintrc.js` files
in `src/common/components` and `src/components` disabling this rule for these
specific packages. I also removed the AntD exports in `src/common/components`
for some of the components that I worked on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
