michael-s-molina commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r580155506
##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -145,13 +146,38 @@ export default class SqlEditorLeftBar extends
React.PureComponent {
<div className="divider" />
<StyledScrollbarContainer>
<StyledScrollbarContent contentHeight={tableMetaDataHeight}>
- {this.props.tables.map(table => (
- <TableElement
- table={table}
- key={table.id}
- actions={this.props.actions}
- />
- ))}
+ <Collapse
+ ghost
+ expandIconPosition="right"
+ css={theme => css`
Review comment:
@simcha90 When styles get bigger, that's generally an indication that
your component should be broken into smaller components. If that's not the
case, if your component is at the atomic level but has a lot of different CSS
states then what I usually do is extract the `css` prop to a variable next to
the component declaration. That way the style is still co-located with the
element and we preserve the benefits listed above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
