yardz commented on a change in pull request #13225:
URL: https://github.com/apache/superset/pull/13225#discussion_r580195020
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTableRow.tsx
##########
@@ -83,7 +83,7 @@ const ActivityTableRow: React.FC<ActivityProps> = ({
<>
{activityList.map(activity => (
<CardStyles
- key={`${activity.item_title}__${activity.time}`}
+ key={`${activity.dashboard_title}__${activity.time}__${activity.id}`}
Review comment:
@ktmud The "infinite cards bug" is a problem with keys (or lack
thereof).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]