ktmud commented on a change in pull request #13225:
URL: https://github.com/apache/superset/pull/13225#discussion_r580063835
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -178,7 +115,13 @@ export default function ActivityTable({
/>
<>
{activityData[activeChild]?.length > 0 ? (
- <ActivityContainer>{renderActivity()}</ActivityContainer>
+ <ActivityContainer>
+ <ActivityTableRow
Review comment:
`TableRow` sounds like a row of a table, but it actually contains the
whole table content for a selected tab. We should probably rename other
`XxxTable` to simply `Recents`, `Dashboards`, `Charts` and `SavedQueries` to
be consistent with section titles, then the single tab content can be named as
`RecentsList`, `DashboardList`, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
