ktmud commented on a change in pull request #13291:
URL: https://github.com/apache/superset/pull/13291#discussion_r580728927
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -139,35 +194,30 @@ export default function ActivityTable({
});
}
- const renderActivity = () => {
- const getRecentRef = (e: ActivityObjects) => {
- if (activeChild === 'Viewed') {
- return e.item_url;
- }
- return e.sql ? `/superset/sqllab?savedQueryId=${e.id}` : e.url;
- };
- return activityData[activeChild].map((e: ActivityObjects) => (
- <CardStyles
- onClick={() => {
- window.location.href = getRecentRef(e);
- }}
- key={e.id}
- >
- <ListViewCard
- loading={loading}
- cover={<></>}
- url={e.sql ? `/superset/sqllab?savedQueryId=${e.id}` : e.url}
- title={getFilterTitle(e)}
- description={`Last Edited: ${moment(
- e.changed_on_utc,
- 'MM/DD/YYYY HH:mm:ss',
- )}`}
- avatar={getIconName(e)}
- actions={null}
- />
- </CardStyles>
- ));
- };
+ const renderActivity = () =>
+ activityData[activeChild].map((e: ActivityObject) => {
+ const url = getEntityUrl(e);
+ const lastActionOn = getEntityLastActionOn(e);
+ return (
+ <CardStyles
+ onClick={() => {
+ window.location.href = url;
+ }}
+ key={url}
Review comment:
Yes, it's guaranteed. The `recent_activity` API removes duplicates and
results for other tabs are just regular filtered lists which has guaranteed
unique items.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
