ktmud commented on a change in pull request #13291:
URL: https://github.com/apache/superset/pull/13291#discussion_r580865380
##########
File path: superset-frontend/src/types/Chart.ts
##########
@@ -44,4 +45,7 @@ export type Slice = {
slice_name: string;
description: string | null;
cache_timeout: number | null;
+ url?: string;
};
+
+export default Chart;
Review comment:
I think one has stricter typing following the backend API response;
another is for temporary chart state on the client side (we should probably
consolidate these two).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
