rusackas opened a new pull request #13296:
URL: https://github.com/apache/superset/pull/13296


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Just a small handful of styles I noticed while touching the 
`.ResultSetButtons` class in #13254. This just moves a few lines out of LESS 
and into Emotion styled components using `gridUnit`. I was on the fence about 
using the `css` prop vs the `styled` approach, but went with the latter since 
if we're to open a hundred of these PRs, I figured it makes sense to go with 
the one that's easier to review, by migrating a unique class to a unique styled 
component. If others prefer the `css` approach, I'll re-jigger this one, and 
follow that pattern going forward.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Passes CI and nobody can tell I did anything at all ;)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to