yardz opened a new pull request #13305: URL: https://github.com/apache/superset/pull/13305
### SUMMARY - Moving the `OmniContainer.tsx` file to `OmniContainer` folder - Split into different files ### TEST PLAN No change in behavior, all tests must pass. Notes: In the type of `omnibar` there are no props `id` or `className`. However, in the original javascript implementation, the prop `className` were being used. I checked that in execution both attributes were send to `<input />`. So to be able to change the file to typescript and implement the tests I split `Ominibar` in another file, with the same interface that was being used in `OminiContainer`. I marked component XXX as `@deprecated` and create a test to ensuring that the input will have the id that was sent... To work correctly, I had to use the "// @ts-ignore" tag before the id attribute. I believe that the correct fix for this is a PR in `omnibar` types or find some other lib that does the same and can meet the implementation requirements. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
