yardz commented on a change in pull request #13305: URL: https://github.com/apache/superset/pull/13305#discussion_r582849585
########## File path: superset-frontend/src/components/OmniContainer/getDashboards.ts ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { t, SupersetClient } from '@superset-ui/core'; +import to from 'await-to-js'; + +interface DashboardItem { + changed_by_name: string; + changed_on: string; + creator: string; + dashboard_link: string; + dashboard_title: string; + id: number; + modified: string; + url: string; +} + +interface Dashboards extends DashboardItem { + title: string; +} + +export const getDashboards = async ( + query: string, +): Promise<(Dashboards | { title: string })[]> => { + // todo: Build a dedicated endpoint for dashboard searching + // i.e. superset/v1/api/dashboards?q=${query} + const [error, response] = await to( + SupersetClient.get({ + endpoint: `/dashboardasync/api/read?_oc_DashboardModelViewAsync=changed_on&_od_DashboardModelViewAsync=desc&_flt_2_dashboard_title=${query}`, + }), + ); + if (error) { + return [{ title: t('An error occurred while fetching dashboards') }]; + } Review comment: @ktmud I know that try / catch produces the same result, but I wanted to show some points. I really like to use `await to` because the code is much more readable and easier to understand. ```ts const [err, resp] = asyncFunc(); if(err)// do something // do something vs try{ const resp = asyncFunc(); // do something }catch(err){ // do something } ``` The first option looks much more like the node's error first pattern. It also makes requests a lot easier. For example, if same request returns an error (status 400) and some useful information in the body (error messages), with `await to` it is very simple to capture. In general, I try to avoid `try/catch` as they break the error first pattern and makes the code a little more complex to read. Not that `try/catch` is very hard, it is because the `await to` is much easier. If you still disagree, I can remove it, but I think it helps to decrease code complexity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
