kgabryje commented on a change in pull request #13210:
URL: https://github.com/apache/superset/pull/13210#discussion_r582007287
##########
File path: superset-frontend/src/explore/components/OptionControls.tsx
##########
@@ -92,7 +92,26 @@ export const LabelsContainer = styled.div`
border-radius: ${({ theme }) => theme.gridUnit}px;
`;
-export const AddControlLabel = styled.div`
+export const DndLabelsContainer = styled.div<{
+ canDrop?: boolean;
+ isOver?: boolean;
+}>`
+ padding: ${({ theme }) => theme.gridUnit}px;
+ border: ${({ canDrop, isOver, theme }) => {
+ if (isOver && canDrop) {
+ return `dashed 1px ${theme.colors.info.dark1}`;
+ }
+ if (isOver && !canDrop) {
+ return `dashed 1px ${theme.colors.error.dark1}`;
+ }
Review comment:
I think that we should also add an indicator for `canDrop && !isOver` so
that user knows where he can drag a column
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
