junlincc commented on a change in pull request #13210: URL: https://github.com/apache/superset/pull/13210#discussion_r582080120
########## File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx ########## @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { useState } from 'react'; +import { useDrop } from 'react-dnd'; +import { isEmpty } from 'lodash'; +import { t, withTheme, SupersetTheme } from '@superset-ui/core'; +import { BaseControlConfig, ColumnMeta } from '@superset-ui/chart-controls'; +import ControlHeader from 'src/explore/components/ControlHeader'; +import { + AddControlLabel, + HeaderContainer, + LabelsContainer, +} from 'src/explore/components/OptionControls'; +import { + DatasourcePanelDndType, + DatasourcePanelDndItem, +} from 'src/explore/components/DatasourcePanel/types'; +import Icon from 'src/components/Icon'; +import OptionWrapper from './components/OptionWrapper'; +import { OptionSelector } from './utils'; + +interface LabelProps extends BaseControlConfig { + name: string; + value: string[] | string | null; + onChange: (value: string[] | string | null) => void; + options: { string: ColumnMeta }; + theme: SupersetTheme; +} + +function DndColumnSelectLabel(props: LabelProps) { + const { value, options } = props; + const optionSelector = new OptionSelector(options, value); + const [groupByOptions, setGroupByOptions] = useState<ColumnMeta[]>( + optionSelector.groupByOptions, + ); + + const [, datasourcePanelDrop] = useDrop({ + accept: DatasourcePanelDndType.COLUMN, + + drop: (item: DatasourcePanelDndItem) => { + optionSelector.add(item.metricOrColumnName); + setGroupByOptions(optionSelector.groupByOptions); + props.onChange(optionSelector.getValues()); + }, + + canDrop: (item: DatasourcePanelDndItem) => + !optionSelector.has(item.metricOrColumnName), + + collect: monitor => ({ + isOver: monitor.isOver(), + canDrop: monitor.canDrop(), + }), + }); + + function onClickClose(index: number) { + optionSelector.del(index); + setGroupByOptions(optionSelector.groupByOptions); + props.onChange(optionSelector.getValues()); + } + + function onShiftOptions(dragIndex: number, hoverIndex: number) { + optionSelector.swap(dragIndex, hoverIndex); + setGroupByOptions(optionSelector.groupByOptions); + props.onChange(optionSelector.getValues()); + } + + function placeHolderRenderer() { + return ( + <AddControlLabel cancelHover> Review comment: This contentious point is almost the same as whether we should have "+" AND "ghost" button for click-to-select, and should we still support FilterBox after having native filter. Most us believe the "ghost" button is more intuitive, while many from the community still prefer the existing way for various reason. In my roadmap google sheet, I stated that the biggest drives of implementing this feature are competitive, marketability, UX improvement. Competitive - Tableau only offers DND, no `select`. The question I have for ya'll is that how can we find out whether offering `select` as well ADD any value? We will find out later during usability or A/B testing. This should be a decision supported by data, let's not make decision for the users. Marketability - Self explanatory, this driver doesn't affect final decision much User Experience - keep both under FF, run test, if having both significantly impact UX in a positive way, why not keeping both? Cost - this is more a stakeholder question. do we want to spend 2x time to maintain 2 sets of feature that achieve basically the same goal, or do we want to spend our engineering/product/QA effort on a set of new feature that brings more value and offers higher ROI? Let's hand over the ball to our designer @mihir174, I'm sure he will take all your feedback and come up with the best solution for our users. @kgabryje @villebro ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
