mistercrunch commented on a change in pull request #13346:
URL: https://github.com/apache/superset/pull/13346#discussion_r583287553
##########
File path: superset/databases/commands/create.py
##########
@@ -54,10 +50,9 @@ def run(self) -> Model:
try:
TestConnectionDatabaseCommand(self._actor,
self._properties).run()
except Exception:
- db.session.rollback()
- stats_logger.incr(
- f"db_connection_failed.{database.db_engine_spec.__name__}"
- )
+ with
event_logger.log_context(action=f"db_connection_failed.{database.db_engine_spec.__name__}"):
+ db.session.rollback()
Review comment:
Maybe `log` should be pessimistic / guaranteed to never raise(?) so that
we don't have to use caution every time we call it? That would mean wrapping
the content of `log` in a `try` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
