mistercrunch edited a comment on pull request #13346:
URL: https://github.com/apache/superset/pull/13346#issuecomment-786311466
I feel like we may want to add `engine` as it's own dimension as opposed to
overloading the action type with it.
Eventually I'd like to add the `engine` to all analytics events that
interact with analytics databases like viewing a chart, running a SQL Lab
query, .
I think you can just pass as a keyword as in
`event_logger.log_context('test_connection_success', engine=engine)`
I made a related comment here:
https://github.com/apache/superset/pull/13223#issuecomment-784666308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
