ktmud commented on pull request #13221: URL: https://github.com/apache/superset/pull/13221#issuecomment-786401870
> I also noticed a few usages of type assertion throughout. I assume they were there for a good reason, but it makes me a bit nervous. Maybe go through one more time to ensure they're all needed? Good call. I did a sweep and managed to find one place that I could optimize: https://github.com/apache/superset/pull/13221/commits/caf3b60b895126d524f2a4a601530ada1c1d399b ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
