etr2460 commented on issue #13351: URL: https://github.com/apache/superset/issues/13351#issuecomment-786755461
Love the suggestions, thanks for driving this! A couple pieces of feedback: > Migration files must have a functional down method to effectively rollback changes introduced in the up method. This isn't always possible, especially when the migration is doing some repair of the metadata (vs. adding/removing columns and tables). See https://github.com/apache/superset/pull/12960 for an example of an impossible migration to write a down method for. Maybe this can be more precise by saying that all migrations that modify the structure of the DB/it's columns must have a down method? > PRs introducing database migrations must include runtime estimates and downtime expectations. Love this, let's plan to add these as fields in the PR template? > Establish Github code owners This will be our first use of code owners I think, do you have any thoughts about using this more broadly across the repo? Or have you only thought about the migration use case so far? Nothing here besides my first point should be considered blocking though, and I'll happily vote +1 on this initiative once the thread is created! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
