robdiciuccio commented on issue #13351: URL: https://github.com/apache/superset/issues/13351#issuecomment-790151411
> > Migration files must have a functional down method to effectively rollback changes introduced in the up method. > This isn't always possible, especially when the migration is doing some repair of the metadata (vs. adding/removing columns and tables). Good point. The primary goal here is to be able to successfully rollback from any migration. The [example](https://github.com/apache/superset/pull/12960) you provided is idempotent and additive, which fits the criteria. How about this updated language? > All migrations must support rollbacks. Migrations must have a functional `downgrade` method to effectively rollback schema changes introduced in the `upgrade` method. If a migration makes changes to data that are not easily undone (e.g. https://github.com/apache/superset/pull/12960), the changes introduced must be non-breaking and idempotent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
