betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583818668
##########
File path: superset/sql_lab.py
##########
@@ -205,7 +206,8 @@ def execute_sql_statement(
):
if SQL_MAX_ROW and (not query.limit or query.limit > SQL_MAX_ROW):
query.limit = SQL_MAX_ROW
- if query.limit:
+ # do not apply limit for databases that don't support LIMIT in the
query
+ if query.limit and db_engine_spec.limit_method !=
LimitMethod.FETCH_MANY:
Review comment:
@dpgaspar we actually don't need this, in `apply_limit_to_sql` it
already keeps the query unmodified if the method if `FETCH_MANY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
