betodealmeida commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583857678
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database:
"Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
This fixes a bug that is almost 3 years old! :-P
https://github.com/apache/superset/pull/4947/files#diff-c1b45a05045ffe619c4c4fcd6b3d521a1875f21865a60c32a845f30ef86b95c3R106
The bug was never triggered because we didn't have any DB engine specs using
`LimitMethod.FETCH_ALL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
