ktmud commented on a change in pull request #13305: URL: https://github.com/apache/superset/pull/13305#discussion_r583863953
########## File path: superset-frontend/src/components/OmniContainer/index.tsx ########## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React, { useRef, useState } from 'react'; +import { styled } from '@superset-ui/core'; +import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags'; +import Modal from 'src/common/components/Modal'; +import { useComponentDidMount } from 'src/common/hooks/useComponentDidMount'; +import { Omnibar } from './Omnibar'; +import { LOG_ACTIONS_OMNIBAR_TRIGGERED } from '../../logger/LogUtils'; Review comment: Not a big deal but we prefer absolute paths nowadays. ########## File path: superset-frontend/src/components/OmniContainer/Omnibar.tsx ########## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React from 'react'; +import OmnibarDeprecated from 'omnibar'; + +interface Props { + id: string; + placeholder: string; + extensions: ((query: string) => Promise<any>)[]; +} + +/** + * @deprecated Component "omnibar" does not support prop className or id (the original implementation used className). However, the original javascript code was sending these prop and was working correctly. lol + * As this behavior is unpredictable, and does not works whitch types, I have isolated this component so that in the future a better solution can be found and implemented. + * We need to find a substitute for this component or some way of working around this problem Review comment: Thanks for the notes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
